chore: update core #1807
chore: update core #1807
Conversation
chris-olszewski
force-pushed
the
olszewski/update_core
branch
from
45078d0 to
546c149
Compare
chris-olszewski
force-pushed
the
olszewski/update_core
branch
from
ab40243 to
cb60d7c
Compare
| stickyQueueScheduleToStartTimeout: '10s', | ||
| maxHeartbeatThrottleInterval: '60s', | ||
| defaultHeartbeatThrottleInterval: '30s', | ||
| skipClientWorkerSetCheck: false, |
There was a problem hiding this comment.
Should we be worried about defaulting this to false? I see we had to explicitly set this to true in many of our tests. Is there any risk that this might break users deployments or CIs?
There was a problem hiding this comment.
CIs may break if their tests are running in parallel and using the same default namespace + task queue + same client, Would that be considered a breaking change? This path is now an error, whereas previously it just ignored duplicate registrations. Tests don't care about this req, but now they'll hit errors. Not sure if TS runs their tests in parallel, but rust hit this error in tests
There was a problem hiding this comment.
I took this from the PR that bumped this in Python: https://github.com/temporalio/sdk-python/pull/1157/files#diff-71bb79f8f6f7277331d9df6e0c1de02a9b08a91977289ddf876398e8ad5a8d53R151
@yuandrew is this a concern?
3 participants
What was changed
TSIA
Why?
With the code moving, updating core is more involved than usual. Doing this in a separate PR to make it easier to review.
Checklist
Closes N/A
How was this tested:
Existing tests
Any docs updates needed?
I do not believe so